Add some types & ignore console on APIs & tests

This commit is contained in:
Aarni Halinen
2021-03-15 20:54:43 +02:00
parent febbdea203
commit 03bc750eea
10 changed files with 19 additions and 13 deletions
+1
View File
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
import axios from "axios";
import Event from "@models/Event";
import { getAuthHeader } from "@utils/auth";
+1
View File
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
import axios from "axios";
import Post from "@models/Feed";
import { getAuthHeader } from "@utils/auth";
+1
View File
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
import axios from "axios";
import JobAd from "@models/JobAd";
import { getAuthHeader } from "@utils/auth";
+1
View File
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
import axios from "axios";
import { Signup, SignupForm } from "@models/Signup";
import { getAuthHeader } from "@utils/auth";
+1
View File
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
import axios from "axios";
import Tag from "@models/Tag";
+1 -1
View File
@@ -12,7 +12,7 @@ export enum IconType {
interface IconProps {
name: IconType;
link?: string;
onClick?: (event?: any) => void;
onClick?: React.MouseEventHandler<HTMLSpanElement>;
}
const nameToIcon = (name: IconType): JSX.Element | string => {
@@ -10,7 +10,7 @@ interface OptionsWidgetProps {
}
class OptionsWidget extends React.Component<OptionsWidgetProps> {
handleListOptionsChange = (questions: Question[], index: number) => (event) => {
handleListOptionsChange = (questions: Question[], index: number): React.ChangeEventHandler<HTMLInputElement> => (event) => {
const { onChange } = this.props;
const val = event.target.value;
const lst = val.split(",").map((p) => p.trimLeft());
@@ -19,15 +19,15 @@ class OptionsWidget extends React.Component<OptionsWidgetProps> {
onChange(questions);
};
handleTextOptionsChange = (questions: Question[], index: number) => (event) => {
handleTextOptionsChange = (questions: Question[], index: number): React.ChangeEventHandler<HTMLInputElement> => (event) => {
const { onChange } = this.props;
const val = event.target.value;
// eslint-disable-next-line no-param-reassign
questions[index].options = val;
questions[index].options = val as unknown as string[]; // TODO: Check type
onChange(questions);
};
handleIntegerOptionsChange = (questions: Question[], index: number) => (event) => {
handleIntegerOptionsChange = (questions: Question[], index: number): React.ChangeEventHandler<HTMLInputElement> => (event) => {
const { onChange } = this.props;
const val = event.target.value;
if (val !== "") {
@@ -43,7 +43,7 @@ class OptionsWidget extends React.Component<OptionsWidgetProps> {
onChange(questions);
};
handleRequiredChange = (questions: Question[], index: number) => (event) => {
handleRequiredChange = (questions: Question[], index: number): React.ChangeEventHandler<HTMLInputElement> => (event) => {
const { onChange } = this.props;
const val: boolean = event.target.checked;
console.log(val);
@@ -1,4 +1,4 @@
import React from "react";
import React, { ReactNode } from "react";
import styled from "styled-components";
import { Draggable } from "react-beautiful-dnd";
import { colors } from "@theme/colors";
@@ -17,8 +17,8 @@ const WidgetRow = styled.div`
interface QuestionListProps {
questions: Question[];
innerRef: any;
placeholder: any;
innerRef: React.Ref<HTMLDivElement>;
placeholder: ReactNode;
onChange: (value: Question[]) => void;
}
+4 -4
View File
@@ -9,8 +9,8 @@ import SignupApi from "@api/signupApi";
import { Button } from "@components/index";
import noop from "@utils/noop";
const StyledButton = styled(Button) <{ colorOverride: "red" | "green" }>`
background-color: ${(p: any) => p.colorOverride};
const StyledButton = styled(Button) <{ $colorOverride: "red" | "green" }>`
background-color: ${(p) => p.$colorOverride};
`;
const SignupEmailPage: NextPage = () => {
@@ -64,7 +64,7 @@ const SignupEmailPage: NextPage = () => {
))}
<th>
<CSVLink data={CSVData} headers={questions.map((q) => q.title)} separator=";">
<StyledButton colorOverride="green" buttonStyle="filled" onClick={noop}>
<StyledButton $colorOverride="green" buttonStyle="filled" onClick={noop}>
Download CSV
</StyledButton>
</CSVLink>
@@ -81,7 +81,7 @@ const SignupEmailPage: NextPage = () => {
</td>
))}
<td>
<StyledButton colorOverride="red" buttonStyle="filled" onClick={() => confirmDelete(s, questions[0])}>
<StyledButton $colorOverride="red" buttonStyle="filled" onClick={() => confirmDelete(s, questions[0])}>
Delete
</StyledButton>
</td>
+1
View File
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
import { Selector, ClientFunction, RequestLogger } from "testcafe";
import axios from "axios";