Write some unit tests for excel stuff

members/views/utils.py

@@ -35,8 +35,8 @@ class MemberDetail(generics.RetrieveAPIView):
     throttle_classes = (BurstRateThrottle, SustainedRateThrottle, )
 
 
-def error_view(request, message):
-    return render(request, 'error.html', {'error': str(message)})
+def error_view(request, message, status=400):
+    return render(request, 'error.html', {'error': message}, status=400)
 
 
 def validate_recaptcha(response):
@@ -116,9 +116,7 @@ def import_csv(request, *args, **kwargs):
         delimiter = request.POST.get('delimiter', ',')
         payment_source = request.POST['payment_source']
     except:
-        return render(request,
-                      'error.html',
-                      {'error': _('Missing CSV file')})
+        return error_view(request, _('Missing CSV file'))
 
     try:
         result = MemberForm.csv_to_models(data, payment_source=payment_source, delimiter=delimiter)
@@ -127,7 +125,7 @@ def import_csv(request, *args, **kwargs):
         return error_view(request, ex.form_errors)
     except Exception as ex:
         logging.exception('Other error in CSV import')
-        return error_view(request, ex)
+        return error_view(request, str(ex))
 
     member_table = MemberTable(result.members,
                                request=request,