Fix payment autocomplete permissions and remove test skips

Fixed decorators in urls.py. Moved to method_decorators on view class
This commit is contained in:
Aarni Halinen
2018-07-24 18:19:57 +03:00
parent 7e821f277f
commit 3676f23f65
3 changed files with 3 additions and 7 deletions
-2
View File
@@ -64,7 +64,6 @@ class MemberRegisterTestCase(TestCase):
self.assertEqual(response.status_code, 200) self.assertEqual(response.status_code, 200)
@skip("TODO: Fix")
def test_autocomplete_search_found(self): def test_autocomplete_search_found(self):
"""Test member autocomplete search""" """Test member autocomplete search"""
search_terms = 'Tidus' search_terms = 'Tidus'
@@ -72,7 +71,6 @@ class MemberRegisterTestCase(TestCase):
results = response.json()['results'] results = response.json()['results']
self.assertEqual(len(results), 1) self.assertEqual(len(results), 1)
@skip("TODO: Fix")
def test_autocomplete_search_not_found(self): def test_autocomplete_search_not_found(self):
"""Test member autocomplete search""" """Test member autocomplete search"""
search_terms = 'Notfound' search_terms = 'Notfound'
+1 -5
View File
@@ -45,10 +45,6 @@ from members.views import application_submit
favicon_view = RedirectView.as_view( favicon_view = RedirectView.as_view(
url='static/img/favicon.ico', permanent=True) url='static/img/favicon.ico', permanent=True)
member_autocomplete_view = login_required(
permission_required('members.change_member', login_url='/admin/login')
)
urlpatterns = [ urlpatterns = [
# landing page # landing page
@@ -126,7 +122,7 @@ urlpatterns = [
# member select autocomplete view # member select autocomplete view
url( url(
r'^member-autocomplete/$', r'^member-autocomplete/$',
member_autocomplete_view, MemberAutoComplete.as_view(),
name='member-autocomplete', name='member-autocomplete',
), ),
+2
View File
@@ -217,6 +217,8 @@ def member_edit(request, *args, **kwargs):
request, 'member_edit.html', {'member_id': i, 'form': form}) request, 'member_edit.html', {'member_id': i, 'form': form})
@method_decorator(login_required(login_url='/admin/login'), name='dispatch')
@method_decorator(permission_required('members.change_member'), name='dispatch')
class MemberAutoComplete(autocomplete.Select2QuerySetView): class MemberAutoComplete(autocomplete.Select2QuerySetView):
def get_queryset(self): def get_queryset(self):